Discussion:
[ORLinux] [PATCH] Add bitops include needed for ext2 filesystem
Sebastian Macke
2013-02-13 19:59:48 UTC
Permalink
---
arch/openrisc/include/asm/bitops.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/openrisc/include/asm/bitops.h
b/arch/openrisc/include/asm/bitops.h
index a9e11ef..0c8a5b2 100644
--- a/arch/openrisc/include/asm/bitops.h
+++ b/arch/openrisc/include/asm/bitops.h
@@ -56,4 +56,6 @@
#include <asm-generic/bitops/non-atomic.h>
#include <asm-generic/bitops/ext2-atomic.h>

+#include <asm-generic/bitops/le.h>
+
#endif /* __ASM_GENERIC_BITOPS_H */
--
1.7.5.4
Jonas Bonn
2013-02-15 07:00:25 UTC
Permalink
Hi Sebastian,

Thanks for the patch.

On 02/13/13 20:59, Sebastian Macke wrote:

You need to provide a Signed-off-by: tag on your patch.
Post by Sebastian Macke
---
arch/openrisc/include/asm/bitops.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/openrisc/include/asm/bitops.h
b/arch/openrisc/include/asm/bitops.h
index a9e11ef..0c8a5b2 100644
--- a/arch/openrisc/include/asm/bitops.h
+++ b/arch/openrisc/include/asm/bitops.h
@@ -56,4 +56,6 @@
#include <asm-generic/bitops/non-atomic.h>
#include <asm-generic/bitops/ext2-atomic.h>
+#include <asm-generic/bitops/le.h>
+
#endif /* __ASM_GENERIC_BITOPS_H */
I'd also prefer to see the new include added before the ext2-atomic line
in order to remain aligned with include/asm-generic/bitops.h where this
file originally came from.

Other than that, it looks good. I'll just wait for your Signed-off-by
before pulling it.

Thanks,
Jonas

Loading...